Ensure that we hop off the main actor after MainActor.run. #39872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asynchronous functions isolated to global actors hop to the global at the beginning of the function but do not hop back on return. For `MainActor.run`, this means that we would not "hop back" off the main actor after executing the closure, which lead to too much code running on the main thread. Dropping the "async" ensures that we hop back. While we my also want the general "hop back" semantics for asynchronous actor-isolated functions, for now this addresses the problem with `MainActor.run`. Fixes rdar://82138050.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
kavon
approved these changes
Oct 22, 2021
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchronous functions isolated to global actors hop to the global at
the beginning of the function but do not hop back on return. For
MainActor.run, this means that we would not "hop back" off the mainactor after executing the closure, which lead to too much code running
on the main thread. Dropping the "async" ensures that we hop back.
While we my also want the general "hop back" semantics for
asynchronous actor-isolated functions, for now this addresses the
problem with
MainActor.run.Fixes rdar://82138050.